-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Add .wit interface #203
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Do we also plan to have the generation upstreamed here or in the new repo @ospencer ? Can't do much more, without that but the |
What do you mean? |
Correct me if I'm wrong but my understanding was that these If that's correct, I don't think the process of this generation is shared anywhere? |
Yes, that's true. I see what you mean. I'm sort of against having an automated process/script to do it since it's unstable and only works for JS because of a hack (and this wit file isn't checked in). For reference though, the command to generate the JS files is |
Once we do the breaking changes to make bindgen work, we'll definitely have it automated for as many languages as possible. |
Sounds good, thanks for elaborating! |
Draft because Reactr does not conform to canonical ABI, so this wit file cannot be used to generate bindings that will "just work."