fix: add proto roundtrips for Spark tests and fix issues it surfaces #906
Annotations
2 errors
Build with Gradle:
task ':core:spotlessJavaCheck'#L1
Execution failed for task ':core:spotlessJavaCheck':
The following files had format violations:
src/main/java/io/substrait/relation/Set.java
@@ -63,12 +63,16 @@
··············List<Type>·fields·=·new·ArrayList<>();
··············for·(int·i·=·0;·i·<·a.fields().size();·i++)·{
-··················//·We·intentionally·don't·validate·that·the·types·match,·to·maintain·backwards·compatibility.
-··················//·We·should,·but·then·we'll·need·to·handle·things·like·VARCHAR·vs·FIXEDCHAR·(comes·up·in·Isthmus·tests).
-··················//·We·also·don't·recurse·into·nullability·of·the·inner·fields,·in·case·the·type·itself·is·a·struct·or·list·or·map.
-··················Type·typeA·=·a.fields().get(i);
-··················Type·typeB·=·b.fields().get(i);
-··················fields.add(typeA.nullable()·!=·typeB.nullable()·?·TypeCreator.asNullable(typeA)·:·typeA);
+················//·We·intentionally·don't·validate·that·the·types·match,·to·maintain·backwards
+················//·compatibility.
+················//·We·should,·but·then·we'll·need·to·handle·things·like·VARCHAR·vs·FIXEDCHAR·(comes
+················//·up·in·Isthmus·tests).
+················//·We·also·don't·recurse·into·nullability·of·the·inner·fields,·in·case·the·type
+················//·itself·is·a·struct·or·list·or·map.
+················Type·typeA·=·a.fields().get(i);
+················Type·typeB·=·b.fields().get(i);
+················fields.add(
+····················typeA.nullable()·!=·typeB.nullable()·?·TypeCreator.asNullable(typeA)·:·typeA);
··············}
··············return·Type.Struct.builder()
@@ -79,7 +83,6 @@
········.orElseThrow(()·->·new·IllegalStateException("A·Set·relation·needs·at·least·one·input"));
··}
-
··@OverRide
··public·<O,·E·extends·Exception>·O·accept(RelVisitor<O,·E>·visitor)·throws·E·{
····return·visitor.visit(this);
Run './gradlew :core:spotlessApply' to fix these violations.
at com.diffplug.gradle.spotless.SpotlessCheck.performAction(SpotlessCheck.java:111)
at com.diffplug.gradle.spotless.SpotlessCheck.performAction(SpotlessCheck.java:53)
at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:125)
at org.gradle.api.internal.project.taskfactory.StandardTaskAction.doExecute(StandardTaskAction.java:58)
at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:51)
at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:29)
at org.gradle.api.internal.tasks.execution.TaskExecution$3.run(TaskExecution.java:244)
at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:30)
at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:27)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:67)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:60)
at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:167)
at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:60)
at org.gradle.internal.operations.DefaultBuildOperationRunner.run(DefaultBuildOperationRunner.java:48)
at org.gradle.api.internal.tasks.execution.TaskExecution.executeAction(TaskExecution.java:229)
at org.gradle.api.internal.tasks.execution.TaskExecution.executeActions(TaskExecution.java:212)
at org.gradle.api.internal.tasks.execution.TaskExecution.executeWithPreviousOutputFiles(TaskExecution.ja
|
Build with Gradle
Process completed with exit code 1.
|
Loading