fix: clean code

substrait-io · Jan 25, 2024 · 4677b9e · 4677b9e
1 parent 1667cd7
commit 4677b9e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/isthmus/src/main/java/io/substrait/isthmus/IsthmusEntryPoint.java b/isthmus/src/main/java/io/substrait/isthmus/IsthmusEntryPoint.java
@@ -28,7 +28,7 @@ public class IsthmusEntryPoint implements Callable<Integer> {
   private String sql;
 
   @Option(
-      names = {"-e", "--sqlExpression"},
+      names = {"-e", "--expression"},
       description = "The sql expression we should parse.")
   private String sqlExpression;
 

diff --git a/isthmus/src/test/script/smoke.sh b/isthmus/src/test/script/smoke.sh
@@ -15,8 +15,14 @@ $CMD 'select * from lineitem where l_orderkey > 10' --create "${LINEITEM}"
 # SQL Query - Aggregate
 $CMD 'select l_orderkey, count(l_partkey) from lineitem group by l_orderkey' --create "${LINEITEM}"
 
-# SQL Expression - Filter
-$CMD --sqlExpression 'l_orderkey > 10' --create "${LINEITEM}"
+# SQL Expression - Literal expression
+$CMD --expression '10'
 
-# SQL Expression - Projection
-$CMD --sqlExpression 'l_orderkey + 9888486986' --create "${LINEITEM}"
+# SQL Expression - Reference expression
+$CMD --expression 'l_suppkey' --create "${LINEITEM}"
+
+# SQL Expression - Filter expression
+$CMD --expression 'l_orderkey > 10' --create "${LINEITEM}"
+
+# SQL Expression - Projection expression
+$CMD --expression 'l_orderkey + 9888486986' --create "${LINEITEM}"