Skip to content

Commit

Permalink
feat: correctly declare api dependencies
Browse files Browse the repository at this point in the history
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
  • Loading branch information
nielspardon committed Feb 27, 2025
1 parent d8f22f7 commit 64c2e7b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions core/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import org.gradle.plugins.ide.idea.model.IdeaModel

plugins {
`maven-publish`
id("java")
id("java-library")
id("idea")
id("antlr")
id("com.google.protobuf") version "0.9.4"
Expand Down Expand Up @@ -84,7 +84,7 @@ dependencies {
testImplementation("org.junit.jupiter:junit-jupiter-api:${JUNIT_VERSION}")
testImplementation("org.junit.jupiter:junit-jupiter-params:${JUNIT_VERSION}")
testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:${JUNIT_VERSION}")
implementation("com.google.protobuf:protobuf-java:${PROTOBUF_VERSION}")
api("com.google.protobuf:protobuf-java:${PROTOBUF_VERSION}")
implementation("com.fasterxml.jackson.core:jackson-databind:${JACKSON_VERSION}")
implementation("com.fasterxml.jackson.core:jackson-annotations:${JACKSON_VERSION}")
implementation("com.fasterxml.jackson.datatype:jackson-datatype-jdk8:${JACKSON_VERSION}")
Expand Down
6 changes: 3 additions & 3 deletions isthmus/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar

plugins {
`maven-publish`
id("java")
id("java-library")
id("idea")
id("com.diffplug.spotless") version "6.19.0"
id("com.github.johnrengelman.shadow") version "8.1.1"
Expand Down Expand Up @@ -79,8 +79,8 @@ val SLF4J_VERSION = properties.get("slf4j.version")
val PROTOBUF_VERSION = properties.get("protobuf.version")

dependencies {
implementation(project(":core"))
implementation("org.apache.calcite:calcite-core:${CALCITE_VERSION}")
api(project(":core"))
api("org.apache.calcite:calcite-core:${CALCITE_VERSION}")
// calcite-core 1.37.0 brings in net.minidev:json-smart:2.5.0 which has a CVE associated with it.
// See: https://osv.dev/vulnerability/GHSA-pq2g-wx69-c263
// This causes the build to fail. Pull in the fixed version until Calcite is updated
Expand Down

0 comments on commit 64c2e7b

Please sign in to comment.