Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isthmus): support for replace #224

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

bvolpato
Copy link
Member

@bvolpato bvolpato commented Feb 6, 2024

Function is available in Calcite and Substrait's functions_string.yaml, so just registering the mapping here.

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2024

CLA assistant check
All committers have signed the CLA.

@bvolpato
Copy link
Member Author

bvolpato commented Feb 6, 2024

Build and Test Java seems broken? Complaining about things unrelated to my change:

/home/runner/work/substrait-java/substrait-java/core/src/test/java/io/substrait/type/proto/LocalFilesRoundtripTest.java:62: error: switch rules are not supported in -source 8

@bvolpato bvolpato force-pushed the register-replace-function branch from 85d1c1c to 05eba1d Compare February 6, 2024 17:30
@bvolpato bvolpato force-pushed the register-replace-function branch from e870857 to a44e5f4 Compare February 6, 2024 19:20
@vbarua vbarua changed the title feat(isthmus): register Replace function to scalar sigs feat(isthmus): support for replace Feb 6, 2024
Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the mapping!

@vbarua vbarua merged commit e96f4ba into substrait-io:main Feb 6, 2024
8 checks passed
@bvolpato bvolpato deleted the register-replace-function branch February 6, 2024 20:33
ajegou pushed a commit to ajegou/substrait-java that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants