-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for empty list literals #227
Merged
vbarua
merged 1 commit into
substrait-io:main
from
patientstreetlight:chris.rice/empty-array-literal
Feb 16, 2024
Merged
feat: add support for empty list literals #227
vbarua
merged 1 commit into
substrait-io:main
from
patientstreetlight:chris.rice/empty-array-literal
Feb 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbarua
reviewed
Feb 10, 2024
core/src/main/java/io/substrait/expression/proto/ProtoExpressionConverter.java
Outdated
Show resolved
Hide resolved
c44b090
to
f0c3bf8
Compare
core/src/main/java/io/substrait/expression/proto/ExpressionProtoConverter.java
Outdated
Show resolved
Hide resolved
f0c3bf8
to
4a92e2b
Compare
vbarua
reviewed
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good. I do have some questions and suggestion in various places.
core/src/main/java/io/substrait/expression/proto/ExpressionProtoConverter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/substrait/expression/proto/ProtoExpressionConverter.java
Show resolved
Hide resolved
isthmus/src/main/java/io/substrait/isthmus/expression/LiteralConstructorConverter.java
Show resolved
Hide resolved
isthmus/src/main/java/io/substrait/isthmus/expression/ExpressionRexConverter.java
Outdated
Show resolved
Hide resolved
isthmus/src/main/java/io/substrait/isthmus/expression/LiteralConstructorConverter.java
Outdated
Show resolved
Hide resolved
isthmus/src/main/java/io/substrait/isthmus/expression/LiteralConstructorConverter.java
Show resolved
Hide resolved
9e1fa06
to
43ed4b2
Compare
BREAKING CHANGE: * ExpressionVisitor has a new method to visit Expression.EmptyListLiteral. Implementors which don’t extend AbstractExpressionVisitor will have to add their own implementation. * Public class LiteralConstructorConverter now requires a TypeConverter to be passed to its constructor. * ExpressionCopyOnWriteVisitor#visitLiteral() may now be called with Expression.EmptyListLiteral.
43ed4b2
to
b19ad8b
Compare
vbarua
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this in! Changes look good 🎉
ajegou
pushed a commit
to ajegou/substrait-java
that referenced
this pull request
Mar 29, 2024
BREAKING CHANGE: ExpressionVisitor now has a `visit(Expression.EmptyListLiteral)` method BREAKING CHANGE: LiteralConstructorConverter constructor now requires a TypeConverter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The substrait proto definition provides a representation of empty list literals which is separate from the
representation of non-empty list literals:
This change gives substrait-java a representation for empty list literals, along with conversions to/from
protobuf and to/from Calcite in Isthmus.
BREAKING CHANGE: