Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spark): enable some missing string functions #308

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

andrew-coleman
Copy link
Contributor

Add mappings for upper/lower/concat/coalesce

Add mappings for upper/lower/concat/coalesce

Signed-off-by: Andrew Coleman <andrew_coleman@uk.ibm.com>
Copy link
Contributor

@Blizzara Blizzara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (don't think my approval counts tho, need @vbarua)

@Blizzara Blizzara merged commit fc8a764 into substrait-io:main Oct 24, 2024
13 checks passed
@Blizzara
Copy link
Contributor

Now it does count :D Thanks @andrew-coleman!

@andrew-coleman andrew-coleman deleted the string_fn branch October 25, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants