Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pojo): support best_effort_filter on ReadRel messages #337

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

freakyzoidberg
Copy link
Contributor

ReadRel spec contains a BestEffortFilter expression that is ignored by the Java ProtoRel and RelProto converter.

Adding support to it, similarly to the existing Filter expression.

Thanks

@CLAassistant
Copy link

CLAassistant commented Mar 5, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@Blizzara Blizzara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems sensible to me!

Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge this in today.

@vbarua vbarua changed the title Add support for Best Effort Filter for ReadRel in ProtoRel and RelProto feat(pojo): support best_effort_filter on ReadRel messages Mar 5, 2025
@vbarua vbarua merged commit 780a0bb into substrait-io:main Mar 5, 2025
12 of 13 checks passed
@freakyzoidberg freakyzoidberg deleted the best-effort-filter branch March 6, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants