-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for runtime_mapping #165
Conversation
…eld() and esb.requestBodySearch().runtimeFields()
will try to check this during the weekend. Thanks @jmaitrehenry for the PR. |
'lookup' | ||
]; | ||
|
||
class RuntimeField { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add doc comments for the class and it's methods? You can check any other file for reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please add a note here mentioning that this feature was added to Elasticsearch in v7.11?
@@ -406,6 +406,74 @@ class RequestBodySearch { | |||
return this; | |||
} | |||
|
|||
/** | |||
* Computes a document property dynamically based on the supplied `script`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a note here mentioning that this feature was added to Elasticsearch in v7.11?
'lookup' | ||
]; | ||
|
||
class RuntimeField { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please add a note here mentioning that this feature was added to Elasticsearch in v7.11?
Thanks for the review @sudo-suhas, I will try to update it in the next few days. |
ping @jmaitrehenry |
please finish it :) |
Hi, I've raised a separate pull request based on @jmaitrehenry 's work to try and get this feature merged. @sudo-suhas If you have some time to review, that would be greatly appreciated. |
Fix #152
Add the support for runtime_mapping like:
This will generate a query like that: