retry: add predicate option (currently only function)

[adrian-gierakowski]

Predicate function is executed with rejection value, if the call returns
a truthy value then the handler is retried, otherwise the promise is
rejected with the original rejection value

[adrian-gierakowski]

partially addresses #122

@suguru03 I decided to implement only the predicate function at first since I need this functionality immediately

Regarding implementing the interface based on assert.rejects I am not sure if it's ok to simply require('assert') given that your library should also work in the browser. I am guessing that you are using something like browserify, which should take care of shimming the assert module?

[suguru03]

👍

[suguru03]

Thanks!
I need to fix some dependencies, I'm gonna release it by the end of day.

[suguru03]

@adrian-gierakowski
I published it on 1.15.0-alpha.0.
You should be able to install it using npm install aigle@next 🙂

I will fix a travis issue tomorrow.

[adrian-gierakowski]

Amazing. Thank you for fast response. Let me know what you think about what I wrote regarding implementing the assert interface.

On Tue, 14 Apr 2020 at 08:36, Suguru Motegi ***@***.***> wrote: @adrian-gierakowski <https://github.com/adrian-gierakowski> I published it on 1.15.0-alpha.0. You should be able to install it using npm install ***@***.*** 🙂 I will fix a travis issue tomorrow. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#123 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACQTQNNTWPRNGZGII3QNHDRMQG6LANCNFSM4MG3HLRQ> .

-- Adrian Gierakowski

[suguru03]

@adrian-gierakowski Sorry for the late reply!

I'm thinking about something like this,

class CustomError extends Error {}
const errorRetry = new CustomError('retry');
// instance
const retryOpts = { limit, predicate: errorRetry };
// or class?
const retryOpts = { limit, predicate: CustomError };
return Aigle.retry(retryOpts, () => {});

What do you think? 🤔

I usually use assert.rejects(promise, errrorRetry) and it's really useful.

[adrian-gierakowski]

@adrian-gierakowski Sorry for the late reply!

I'm thinking about something like this,

class CustomError extends Error {}
const errorRetry = new CustomError('retry');
// instance
const retryOpts = { limit, predicate: errorRetry };
// or class?
const retryOpts = { limit, predicate: CustomError };
return Aigle.retry(retryOpts, () => {});

What do you think? 🤔

I usually use assert.rejects(promise, errrorRetry) and it's really useful.

Looks good. So I'm assuming I'll be ok to use 'assert' module to implement this and it will be shimmed by whatever library you use to create the browser release?

[suguru03]

I would rather add some code than depend on other libraries. I'm also thinking to support Deno in the future. 😄
Could you add the handling? I don't think it is a big change.