Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve the robustness of the firehose consumer example #294

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

DrChat
Copy link
Contributor

@DrChat DrChat commented Mar 8, 2025

The example previously treated some websocket control frames (e.g. pings) as a signal to exit.

When listening from a low volume PDS, this meant that the example would frequently exit if no activity was occurring.

@sugyan sugyan merged commit f162f81 into sugyan:main Mar 9, 2025
14 checks passed
@sugyan
Copy link
Owner

sugyan commented Mar 9, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants