Merge pull request #2667 from sul-dlss/2501-aria-roles

Remove redundant aria roles from native semantic HTML elements
sul-dlss · Dec 4, 2024 · 47dbeba · 47dbeba
2 parents bb96b65 + 7cf0e11
commit 47dbeba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/views/layouts/spotlight/base.html.erb b/app/views/layouts/spotlight/base.html.erb
@@ -40,7 +40,7 @@
     <%= javascript_tag "Spotlight.sirTrevorIcon = '#{asset_path('spotlight/blocks/sir-trevor-icons.svg')}'" %>
   </head>
   <body class="<%= render_body_class %>">
-    <nav id="skip-link" role="navigation" class="visually-hidden-focusable visually-hidden visually-hidden-focusable" aria-label="<%= t('blacklight.skip_links.label') %>">
+    <nav id="skip-link" class="visually-hidden-focusable visually-hidden visually-hidden-focusable" aria-label="<%= t('blacklight.skip_links.label') %>">
       <%= link_to t('blacklight.skip_links.search_field'), '#search_field', class: 'd-inline-flex p-2 m-1', data: { turbolinks: 'false' } %>
       <%= link_to t('blacklight.skip_links.main_content'), '#main-container', class: 'd-inline-flex p-2 m-1', data: { turbolinks: 'false' } %>
       <%= content_for(:skip_links) %>
@@ -50,7 +50,7 @@
     <%= render partial: 'shared/masthead' %>
     <%= content_for?(:header_content) ? yield(:header_content) : "" %>
 
-    <main id="main-container" class="<%= container_classes %> mb-5" role="main" aria-label="<%= t('blacklight.main.aria.main_container') %>">
+    <main id="main-container" class="<%= container_classes %> mb-5" aria-label="<%= t('blacklight.main.aria.main_container') %>">
       <%= content_for(:container_header) %>
 
       <%= render partial: 'shared/flash_msg', layout: 'shared/flash_messages' %>

diff --git a/app/views/shared/_footer.html.erb b/app/views/shared/_footer.html.erb
@@ -1,4 +1,4 @@
-<footer role="contentinfo">
+<footer>
   <section id="pre-footer" class="pt-3 pb-2">
     <div class="container">
       <div class="row">