Update to Mirador 4 alpha #2333
Draft
+723
−1,523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
commented
Jan 31, 2025
| * @param theme | ||
| * @returns {{ctrlBtn: {margin: (number|string)}}} | ||
| */ | ||
| const styles = theme => ({ |
There was a problem hiding this comment.
Find out if we need this style...
There was a problem hiding this comment.
This style can provide a class to Mirador here: https://github.com/ProjectMirador/mirador/blob/mui6/src/components/WindowTopMenuButton.js#L34
Visually, this button's background when selected looks to match the other buttons without this class/style.
So it seems on the surface that it isn't needed.
|
🎉 |
cbeer
force-pushed
the
m4-alpha
branch
2 times, most recently
from
6b3e803 to
a63097e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.