Skip to content

Commit

Permalink
Remove unused routes for feedback
Browse files Browse the repository at this point in the history
We only need the post route
  • Loading branch information
jcoyne committed Jan 30, 2025
1 parent a1cbfc7 commit 3b54bff
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 13 deletions.
File renamed without changes.
14 changes: 6 additions & 8 deletions app/views/shared/_sul_header.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,17 @@
<li>
<%= link_to t('.my_account'), "https://mylibrary.stanford.edu/" %>
</li>
<% unless current_page?(feedback_form_path) %>
<li>
<%= link_to "#feedback-form", role: 'button', data: {'bs-toggle':"collapse", 'bs-target':"#feedback-form"} do %>
Feedback
<% end %>
</li>
<% end %>
<li>
<%= link_to "#feedback-form", role: 'button', data: {'bs-toggle':"collapse", 'bs-target':"#feedback-form"} do %>
Feedback
<% end %>
</li>
</ul>
</nav>
</div>
</div>
<div id="feedback-form" class="feedback-form-container collapse">
<%= render template: 'feedback_forms/new' unless current_page?(feedback_form_path) %>
<%= render 'feedback_forms/new' %>
</div>
<!-- Application header -->
<div id="app-header" class="text-white bg-cardinal py-3 d-flex">
Expand Down
3 changes: 1 addition & 2 deletions config/routes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,5 @@
post :comment, as: :comment
end
end
resource :feedback_form, path: 'feedback', only: %I[new, create]
get 'feedback' => 'feedback_forms#new'
resource :feedback_form, path: 'feedback', only: :create
end
6 changes: 3 additions & 3 deletions spec/requests/feedback_forms_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

require 'rails_helper'

RSpec.describe 'FeedbackForm', type: :feature do
RSpec.describe 'The feedback form', type: :feature do
let(:current_user?) { false }
let(:user) { create(:sso_user) }

context 'when not logged in' do
it 'reCAPTCHA challenge is present' do
visit feedback_path
visit root_path
expect(page).to have_css '.requests-captcha'
end
end
Expand All @@ -19,7 +19,7 @@
end

it 'reCAPTCHA challenge is NOT present' do
visit feedback_path
visit root_path
expect(page).to have_no_css '.requests-captcha'
end

Expand Down

0 comments on commit 3b54bff

Please sign in to comment.