Replace 'Unavailable' with 'Not requestable'; fixes #2005

app/models/folio/item.rb

@@ -111,7 +111,7 @@ def status_class
 
     # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
     def status_text
-      return temporary_location&.discovery_display_name || 'Unavailable' unless requestable?
+      return temporary_location&.discovery_display_name || 'Not requestable' unless requestable?
 
       if !circulates?
         'In-library use only'
@@ -120,7 +120,7 @@ def status_text
       elsif hold_recallable?
         status
       else
-        'Unavailable'
+        'Not requestable'
       end
     end
     # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
@@ -214,7 +214,7 @@ def self.from_hash(dyn)
     def availability_class
       if hold_recallable?
         'hold-recall'
-      elsif effective_location.details['availabilityClass'] == 'Offsite'
+      elsif effective_location.details['availabilityClass'] == 'Offsite' && requestable?
         'deliver-from-offsite'
       elsif status == STATUS_AVAILABLE && requestable?
         'available'

spec/factories/folio_api_json.rb

@@ -768,4 +768,25 @@
       new(**attributes)
     end
   end
+
+  factory :aged_to_lost_holdings, class: 'Folio::Instance' do
+    id { '1234' }
+    title { 'One lost item' }
+
+    format { ['Book'] }
+
+    items do
+      [
+        build(:item,
+              barcode: '12345678',
+              callnumber: 'ABC 123',
+              status: 'Aged to Lost',
+              effective_location: build(:location, code: 'SAL3-STACKS'))
+      ]
+    end
+
+    initialize_with do
+      new(**attributes)
+    end
+  end
 end

spec/helpers/requests_helper_spec.rb

@@ -233,6 +233,20 @@
         expect(subject).to have_content('In-library use only')
       end
     end
+
+    describe 'with a non-pageable item' do
+      let(:holding) do
+        build(:aged_to_lost_holdings).items.first
+      end
+
+      it 'includes the status icon' do
+        expect(subject).to have_css('.unavailable')
+      end
+
+      it 'includes the status text' do
+        expect(subject).to have_content('Not requestable')
+      end
+    end
   end
 
   describe '#request_level_request_status' do