This repository has been archived by the owner on Jan 28, 2025. It is now read-only.
WIP (Request for comments) Relay one post's content; fallback to description #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`post.description` returns only a summary. In order to get the full description we read post content fallbacking to description if the former does not exist.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
post.descriptionsometime returns only a summary.Proposed solution:
In order to get the full description we read
post.content[0].valueand we fallback topost.descriptionif theformer does not exist.
Request for comments:
I couldn't figure out why the posts of some feeds only give me a summary when I call
post.description. It happen with RSS and Atom feeds.Using
post.content[0].valueis a hack:content: could we select one based on thetype?post.content?The change will not be backward compatible so probably we should add a flag in the command line or something similar and enable this feature/workaround/hack optionally.
This PR is obviously a work in progress.