Skip to content

Commit

Permalink
Fixed error in effective area calculation where mirror reflectivity w…
Browse files Browse the repository at this point in the history
…as only counted once
  • Loading branch information
danseaton committed Jun 10, 2024
1 parent eab9e76 commit 545129d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion suncet_instrument_simulator/instrument.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def compute_effective_area(self):
quantum_efficiency = self.__interpolate_quantum_efficiency()

wavelength_strings = [f"{wavelength.value} {wavelength.unit}" for wavelength in self.wavelengths]
effective_area = geometric_area * mirror_reflectivity * filter_transmission * quantum_efficiency
effective_area = geometric_area * mirror_reflectivity**2. * filter_transmission * quantum_efficiency
self.effective_area = {wavelength_str: a_eff for wavelength_str, a_eff in zip(wavelength_strings, effective_area)}


Expand Down

0 comments on commit 545129d

Please sign in to comment.