Merge branch 'master' of github-sunrise-php:sunrise-php/vin

sunrise-php · Mar 5, 2019 · e1c13dd · e1c13dd
2 parents b38068a + ead0a27
commit e1c13dd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/composer.json b/composer.json
@@ -20,7 +20,7 @@
         "php": "^7.1"
     },
     "require-dev": {
-        "phpunit/phpunit": "7.5.4"
+        "phpunit/phpunit": "7.5.6"
     },
     "autoload": {
         "files": [

diff --git a/src/VinInterface.php b/src/VinInterface.php
@@ -19,16 +19,6 @@
  */
 interface VinInterface
 {
-
-	/**
-	 * Constructor of the class
-	 *
-	 * @param string $value
-	 *
-	 * @throws \InvalidArgumentException If the given value is not a valid VIN
-	 */
-	public function __construct(string $value);
-
 	/**
 	 * Gets the VIN
 	 *

diff --git a/tests/VinTest.php b/tests/VinTest.php
@@ -20,13 +20,15 @@ public function testConstructor()
 	public function testVinLessThan17Characters()
 	{
 		$this->expectException(\InvalidArgumentException::class);
+		$this->expectExceptionMessage('The value "AAAAAAAAAAAAAAAA" is not a valid VIN');
 
 		new Vin(\str_repeat('A', 16));
 	}
 
 	public function testVinMoreThan17Characters()
 	{
 		$this->expectException(\InvalidArgumentException::class);
+		$this->expectExceptionMessage('The value "AAAAAAAAAAAAAAAAAA" is not a valid VIN');
 
 		new Vin(\str_repeat('A', 18));
 	}
@@ -37,6 +39,7 @@ public function testVinMoreThan17Characters()
 	public function testVinWithForbiddenCharacters($value)
 	{
 		$this->expectException(\InvalidArgumentException::class);
+		$this->expectExceptionMessage(\sprintf('The value "AAAAAAAAAAAAAAAA%s" is not a valid VIN', $value));
 
 		new Vin(\str_repeat('A', 16) . $value);
 	}