Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip hashing empty secret values #3115

Merged
merged 2 commits into from
Feb 7, 2025
Merged

fix: skip hashing empty secret values #3115

merged 2 commits into from
Feb 7, 2025

Conversation

sweatybridge
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix, feature, docs update, ...

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner February 7, 2025 05:56
@coveralls
Copy link

coveralls commented Feb 7, 2025

Pull Request Test Coverage Report for Build 13194397490

Details

  • 12 of 15 (80.0%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 58.257%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/config.go 8 9 88.89%
pkg/config/secret.go 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 13174729046: 0.0%
Covered Lines: 7673
Relevant Lines: 13171

💛 - Coveralls

@sweatybridge sweatybridge merged commit e2b04d0 into develop Feb 7, 2025
17 checks passed
@sweatybridge sweatybridge deleted the fix-secret branch February 7, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants