Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exists method raises error when no file found #335

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix: exists method raises error when no file found #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions storage3/_async/file_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,11 +357,14 @@ async def exists(
path
The path to the file.
"""
response = await self._request(
"HEAD",
f"/object/info/{self.id}/{path}",
)
return response.status_code == 200
try:
response = await self._request(
"HEAD",
f"/object/{self.id}/{path}",
)
return response.status_code == 200
except json.JSONDecodeError:
return False

async def list(
self,
Expand Down
13 changes: 8 additions & 5 deletions storage3/_sync/file_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,11 +357,14 @@ def exists(
path
The path to the file.
"""
response = self._request(
"HEAD",
f"/object/info/{self.id}/{path}",
)
return response.status_code == 200
try:
response = self._request(
"HEAD",
f"/object/{self.id}/{path}",
)
return response.status_code == 200
except json.JSONDecodeError:
return False

def list(
self,
Expand Down
Loading