Optimizations #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly after the models are loaded
…e baking and not all in black, material.vertexColors=THREE.VertexColors is done by the aobake component, but material.needsUpdate=true was missing to properly see the baked vertex colors
…ed geometry, properly dispose previous geometry
|
I recently did some tests with baking AO to vertex colors in blender 3.2. It would be interesting to compare it with the result produced by this component and after #1 is done. I may contribute a CC0 glb model of a table and seats (a cube and cylinders) and a new example to show the difference between no baking, baking with blender and baking with this component. |
|
See this Three Lightmap Baker https://twitter.com/_LucasJones/status/1571961989248995330 that uses Three Mesh BVH, Three GPU Pathtracer & XAtlas-Three |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing with this old component, and dug a little bit into how it works. I ended up optimizing it a bit, the time to bake decreased from 14s to 10s on a more heavy scene I was testing.
I also took the optimizations of the octree that was made in mrdoob/three.js#21834
I may continue working on it or not, but here are some of future tasks I was thinking to do: