Merge pull request #438 from superform-xyz/SUP-5255

chore: superformfactory and superregistry
superform-xyz · Jan 18, 2024 · d8ed672 · d8ed672
2 parents a36f0df + fcf1533
commit d8ed672
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/test/unit/super-registry/SuperRegistry.t.sol b/test/unit/super-registry/SuperRegistry.t.sol
@@ -346,7 +346,7 @@ contract SuperRegistryTest is BaseSetup {
         superRegistry.setRequiredMessagingQuorum(OP, 5);
     }
 
-    function test_set_delay() public {
+    function test_setDelay() public {
         vm.prank(deployer);
         vm.expectRevert(Error.INVALID_TIMELOCK_DELAY.selector);
         superRegistry.setDelay(5 minutes);
@@ -359,6 +359,12 @@ contract SuperRegistryTest is BaseSetup {
         superRegistry.setDelay(11 hours);
     }
 
+    function test_setQuorum_invalid_chainId() public {
+        vm.prank(deployer);
+        vm.expectRevert(Error.INVALID_CHAIN_ID.selector);
+        superRegistry.setRequiredMessagingQuorum(0,2);
+    }
+
     function test_getAmbId() public {
         uint256 ambId_ = superRegistry.getAmbId(getContract(ETH, "LayerzeroImplementation"));
         assertEq(ambId_, 1);

diff --git a/test/unit/superform-factory/superform-factory.createSuperforms.t.sol b/test/unit/superform-factory/superform-factory.createSuperforms.t.sol
@@ -197,6 +197,28 @@ contract SuperformFactoryCreateSuperformTest is BaseSetup {
         SuperformFactory(getContract(chainId, "SuperformFactory")).getSuperform(superformId);
     }
 
+    function test_getAllSuperformsFromVault() public {
+        vm.startPrank(deployer);
+        vm.selectFork(FORKS[chainId]);
+        address superRegistry = getContract(chainId, "SuperRegistry");
+        /// @dev Deploying Forms
+        address formImplementation = address(new ERC4626Form(superRegistry));
+        address formImplementation2 = address(new ERC4626Form(superRegistry));
+
+        // Deploying Forms Using AddImplementation. Not Testing Reverts As Already Tested
+        SuperformFactory(getContract(chainId, "SuperformFactory")).addFormImplementation(
+            formImplementation, 420, 1
+        );
+
+        SuperformFactory(getContract(chainId, "SuperformFactory")).addFormImplementation(
+            formImplementation2, 69, 1
+        );
+
+        SuperformFactory(getContract(chainId, "SuperformFactory")).createSuperform(420, vault);
+        SuperformFactory(getContract(chainId, "SuperformFactory")).createSuperform(69, vault);
+        SuperformFactory(getContract(chainId, "SuperformFactory")).getAllSuperformsFromVault(vault);
+    }
+
     function test_initializeWithZeroAddressAsset() public {
         vm.selectFork(FORKS[chainId]);
         address zeroAssetVault = address(new ZeroAssetVault());