Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rearrange final token validation #428

Merged
merged 5 commits into from
Jan 17, 2024
Merged

chore: rearrange final token validation #428

merged 5 commits into from
Jan 17, 2024

Conversation

sujithsomraaj
Copy link
Contributor

No description provided.

@linear Linear
Copy link

linear bot commented Jan 16, 2024

SUP-5151 Fix Final Token Validation For Failed DstSwap in CSR

0xTimepunk
0xTimepunk requested changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@0xTimepunk 0xTimepunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comments

0xTimepunk
0xTimepunk reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@0xTimepunk 0xTimepunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Could just use more testing of the new reverts that were moved inside if else for full coverage

@0xTimepunk 0xTimepunk merged commit 64fb243 into develop Jan 17, 2024
6 checks passed
@0xTimepunk 0xTimepunk deleted the SUP-5151 branch January 17, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTimepunk 0xTimepunk 0xTimepunk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sujithsomraaj @0xTimepunk