fix: remedy rounding issue in _deposit4626() by adding remainder to _deposit() call
#657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xTimepunk
approved these changes
Nov 25, 2024
gpersoon
reviewed
Nov 28, 2024
| { | ||
| uint256 valuePerItem = (msg.value - (msg.value % arrayLength)) / arrayLength; | ||
| uint256 remainingValue = msg.value % arrayLength; | ||
| valueToDeposit = valuePerItem + remainingValue; |
There was a problem hiding this comment.
the remainingValue should only be used once - for one of the vaults (or discounted in another way, or neglected)
this calculation: uint256 valuePerItem = msg.value / arrayLength can stay as it was because it rounds down anyway
Perhaps do the calculation of the valueToDeposit in the calling function deposit4626() and add the remainingValue only for the last (or first) item in the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uint256 msgValue = msg.value / arrayLength;rounds down so the last bit ofmsg.valueis not used.valuePerItemdeposit()