Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-11330] Double-check whether connection is possible after _buildMountPoint #4

Conversation

kpsroka
Copy link

@kpsroka kpsroka commented Jul 22, 2024

@kpsroka kpsroka requested a review from brian-superlist July 22, 2024 14:49
Copy link

@brian-superlist brian-superlist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting finding! And yes, could explain why we see multiple connections actually.

Could we please add tests for this?

@kpsroka kpsroka merged commit 3e68675 into master Jul 22, 2024
1 check failed
@kpsroka kpsroka deleted the fix/dev-11330-investigate-why-mac-app-opens-two-websocket-connections-in branch July 22, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants