[DEV-11398] Remove workaround for invalid token in PhoenixSocket.connect() #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpsroka
approved these changes
Jul 26, 2024
lib/src/socket.dart
Outdated
| return; | ||
| } else { | ||
| throw PhoenixException(); | ||
| } // else |
There was a problem hiding this comment.
I think you can drop the comment now :D
| expect(phoenixSocket.isConnected, isFalse); | ||
|
|
||
| // first retry after ~10 seconds | ||
| async.elapse(const Duration(seconds: 11)); |
There was a problem hiding this comment.
Time doesn't flow by itself in fakeAsync, you should be able to use exact durations from reconnectDelays. (also below)
There was a problem hiding this comment.
The delay used is coming from the list of reconnect delays passed in options plus a random duration between 0 and 1 second. That's why I went with custom reconnect delays where the 0-1 random second does not get in the way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the workaround for handling an invalid token.
With the old implementation, the client will return
nullas the token in case it can't determine one (e.g. not authentication, token expired, etc.) and thenPhoenixSocket.connect()expects this situation and inspects the token in the socket connection parameters. This package should not care about this implementation detail.Instead, the client should throw an exception when it fails to get a valid token and
PhoenixSocket.connect()should handle that exception when retrieving the (dynamic) parameters from the socket options.