feat: revamp code structure #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
let's fix flake8 linting? |
HanFa
previously approved these changes
Jul 21, 2024
| @@ -198,7 +194,7 @@ def yt_download(video_id): | |||
| exception = e | |||
|
|
|||
| return jsonify({"message": log_error_return_str( | |||
| f'An error occurred while downloading video {video_id} to {video_save_path}: {exception}')}), 500 | |||
| f'An error occurred while downloading video {video_id} to {video_save_path}: {exception}')}), 500 | |||
| en_srt_merged_fn = f'{video_id}_en_merged.srt' | ||
| zh_srt_merged_fn = f'{video_id}_zh_merged.srt' | ||
| en_srt_merged_path = os.path.join(output_path, en_srt_merged_fn) | ||
| zh_srt_merged_path = os.path.join(output_path, zh_srt_merged_fn) | ||
| data = request.get_json() | ||
| video_id = data['video_id'] | ||
| translateVendor = data['translate_vendor'] |
There was a problem hiding this comment.
s/translaterVendor/translator_vendor
app.py
Outdated
| @@ -583,7 +546,8 @@ def tts(video_id): | |||
| shutil.rmtree(tts_dir) | |||
|
|
|||
| try: | |||
| ret = srtToVoiceEdge(app.logger, srt_path, tts_dir, charater) | |||
| tts_client = get_tts_client(charater) | |||
| ret = tts_client.srt_to_voice(srt_path, tts_dir) | |||
There was a problem hiding this comment.
Nice abstraction of TTS client
| "audio zh transcribe": true, | ||
| "audio zh transcribe model": "medium", | ||
| "video zh preview": true | ||
| } |
| "proxy": "127.0.0.1:7890", | ||
| "video Id": "eMlx5fFNoYc", | ||
| "work path": "conver\\cheak_valve", | ||
| "download video": true, |
There was a problem hiding this comment.
Convert those keys to underscore naming conventions
| @@ -6,7 +6,7 @@ | |||
| from tqdm import tqdm | |||
|
|
|||
| try: | |||
| from lib import spec_utils | |||
| from models.audio_removal_model import spec_utils | |||
| except ModuleNotFoundError: | |||
| import spec_utils | |||
|
|
||
| DEFAULT_URL = "https://api.openai.com/v1/" | ||
| GHATGPT_TERMS_FILE = "../../../configs/gpt_terms.json" |
There was a problem hiding this comment.
Use os join from project root
| @@ -3,21 +3,20 @@ | |||
| import concurrent.futures | |||
| import time | |||
| import tenacity | |||
| from .translator import Translator | |||
There was a problem hiding this comment.
svc.service.translator use full path
| @@ -0,0 +1,484 @@ | |||
| # from src.service.audio_processing.audio_remove import audio_remove | |||
HanFa
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains following changes