Fix partial cache write

swan-io · Apr 3, 2024 · 31621fd · 31621fd
1 parent 4e355d2
commit 31621fd
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/src/cache/cache.ts b/src/cache/cache.ts
@@ -129,7 +129,7 @@ export class ClientCache {
     return match(getCacheKeyFromJson(value))
       .with(Option.P.Some(P.select()), (cacheKey) => {
         const existingEntry = this.getOrDefault(cacheKey);
-        this.cache.set(
+        this.set(
           cacheKey,
           mergeCacheEntries(existingEntry, {
             requestedKeys,

diff --git a/src/cache/write.ts b/src/cache/write.ts
@@ -90,15 +90,17 @@ export const writeOperationToCache = (
               }
             }
           } else {
-            cache.updateFieldInClosestCachedAncestor({
-              originalFieldName,
-              fieldNameWithArguments,
-              value: fieldValue,
-              path,
-              ancestors: data,
-              variables: fieldArguments,
-              rootTypename,
-            });
+            if (originalFieldName in parent) {
+              cache.updateFieldInClosestCachedAncestor({
+                originalFieldName,
+                fieldNameWithArguments,
+                value: fieldValue,
+                path,
+                ancestors: data,
+                variables: fieldArguments,
+                rootTypename,
+              });
+            }
           }
         })
         .with({ kind: Kind.INLINE_FRAGMENT }, (inlineFragmentNode) => {