Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify chunk reading #703

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

silverjam
Copy link
Contributor

A "fix" for #702 which removes the superfluous logic that built up an large chunk/upload-part sized buffer from a series of small reads. The original intent of this code was to stream small reads with small buffers up to the chunk/upload-part size. I think the original logic could be brought back with something like http_body_util::StreamBody but this at least removes a superfluous stream and the loop that builds up the buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant