baby steps towards a Structured Concurrency API #806
Merged
+273
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
Feb 5, 2025
There was a problem hiding this comment.
I'm happy with this, but would like @fabianfett to review as well.
This was referenced Feb 5, 2025
FranzBusch
reviewed
Feb 5, 2025
|
I left some Sendable correctness remarks. Overall this looks good to me. |
FranzBusch
reviewed
Feb 6, 2025
Comment on lines
39
to
44
| public static func withHTTPClient<R: Sendable>( | ||
| eventLoopGroup: any EventLoopGroup = HTTPClient.defaultEventLoopGroup, | ||
| configuration: Configuration = Configuration(), | ||
| backgroundActivityLogger: Logger? = nil, | ||
| _ body: @escaping @Sendable (HTTPClient) async throws -> R | ||
| ) async throws -> R { |
There was a problem hiding this comment.
Suggested change
| public static func withHTTPClient<R: Sendable>( | |
| eventLoopGroup: any EventLoopGroup = HTTPClient.defaultEventLoopGroup, | |
| configuration: Configuration = Configuration(), | |
| backgroundActivityLogger: Logger? = nil, | |
| _ body: @escaping @Sendable (HTTPClient) async throws -> R | |
| ) async throws -> R { | |
| public static func withHTTPClient<Result: Sendable>( | |
| eventLoopGroup: any EventLoopGroup = HTTPClient.defaultEventLoopGroup, | |
| configuration: Configuration = Configuration(), | |
| backgroundActivityLogger: Logger? = nil, | |
| _ body: (HTTPClient) async throws -> Result | |
| ) async throws -> Result { |
There was a problem hiding this comment.
That's in the 5.9 part
weissi
force-pushed
the
jw-baby-sc
branch
4 times, most recently
from
11db0bf to
4f6856d
Compare
FranzBusch
approved these changes
Feb 6, 2025
|
Thanks @FranzBusch for advice here! As you know, I still use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment,
HTTPClient's entire API surface violates Structured Concurrency. Both the creation & shutdown of a HTTP client as well as making requests (#807) doesn't follow Structured Concurrency. Some of the problems are:This PR is baby steps towards a Structured Concurrency API, starting with start/shutdown of the HTTP client.