Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nav-title 100% width in mobile viewport #928

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marinaaisa
Copy link
Member

@marinaaisa marinaaisa commented Feb 4, 2025

Bug/issue #137436968, if applicable:

Summary

This is a small change to make the nav-title to be 100% width in mobile viewport instead of 90%.
There was no reason for it to be 90% instead.

Dependencies

NA

Testing

Steps:

  1. Go to any documentation or tutorial page
  2. Assert that the nav title looks correct in mobile viewport

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

@marinaaisa marinaaisa requested a review from mportiz08 February 4, 2025 18:15
Copy link
Contributor

@mportiz08 mportiz08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works better in the common case, but we have overflow issues when the title here is really long:

Screenshot 2025-02-04 at 3 44 15 PM

Is this something we could easily address in the same PR possibly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants