Tests: Augment Command Tests #8276
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkhouri
changed the title
bkhouri
force-pushed
the
t/swb/augment_buildcommand_tests
branch
from
925baa5 to
af97fab
Compare
bkhouri
changed the title
bkhouri
force-pushed
the
t/swb/augment_buildcommand_tests
branch
from
af97fab to
1fb1ed9
Compare
1 task
bkhouri
force-pushed
the
t/swb/augment_buildcommand_tests
branch
3 times, most recently
from
428e6fd to
063da6d
Compare
1 task
1 task
bkhouri
force-pushed
the
t/swb/augment_buildcommand_tests
branch
from
063da6d to
9547011
Compare
Augment Commands Tests to run against the Native and Swift Build build
systems.
- BuildCommandTests
- TestCommandTests
- RunCommandTests
- APIDiffTests
- PackageCommandTests
Also,
- Add a new BuildCommandTest and RunCommandTest test case that ensures
a package with target conditionals builds and runs successfully
- update BuildSystemProvider.Kind to define a "useXcodeBuildSystemPath"
variable instead of sprinkling the `buildSystem == .xcode` all over
the place
- Augment the Swift Build integration test to run `swift test`
TODO:
- Instead of marking test failures as "Skipped", See if we can mark
them as "expected fail" so we are forced to update the test once the
production code has been update to support the "feature".
more update'
This reverts commit 3e06c8f497b33b24aefc18290d9226dea01525e6.
bkhouri
force-pushed
the
t/swb/augment_buildcommand_tests
branch
from
9547011 to
b14a7e1
Compare
bkhouri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augment Commands Tests to run against the Native and Swift Build build systems.
Also,
BuildSystemProvider.Kind.usesXcodeBuildEnginevalue ofswiftbuildtotrueswift testandswift runTODO:
them as "expected fail" so we are forced to update the test once the
production code has been update to support the "feature".
Fixes #8272
Depends on #8271