Deprecate sync methods in RegistryDownloadsManager #8323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
owenv and
bkhouri
as code owners
Deprecate the synchronous methods in RegistryDownloadsManager and move the logic from the existing sync methods to the async methods. The synchronous methods in RegistryDownloadsManager will now warn when used. After some time they can be removed completely. This patch follows the same refactoring conventions as swiftlang#8263
plemarquand
force-pushed
the
asyncify-registry-download-manager
branch
from
1cfeb47 to
c03895f
Compare
jakepetroules
approved these changes
Mar 4, 2025
|
@swift-ci please test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the synchronous methods in RegistryDownloadsManager and move the logic from the existing sync methods to the async methods.
The synchronous methods in RegistryDownloadsManager will now warn when used. After some time they can be removed completely.
This patch follows the same refactoring conventions as #8263