Skip to content

Commit

Permalink
Rename extension ID from swiftlang.swift to swiftlang.swift-vscode (
Browse files Browse the repository at this point in the history
#1358)

Try this one more time.

Because there is already another extension with `swift` as its name,
and the VS Code Marketplace name must be unique (not just the full ID),
switch to the extension ID `swiftlang.swift-vscode`.
  • Loading branch information
plemarquand authored Feb 6, 2025
1 parent 89c52fc commit e4500d6
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 15 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

## 2.0.0 - 2025-01-28

The Swift extension for VS Code has moved to the [official swiftlang organization in the VS Code Marketplace](https://marketplace.visualstudio.com/items?itemName=swiftlang.swift)!
The new extension id is `swiftlang.swift`.
The Swift extension for VS Code has moved to the [official swiftlang organization in the VS Code Marketplace](https://marketplace.visualstudio.com/items?itemName=swiftlang.swift-vscode)!
The new extension id is `swiftlang.swift-vscode`.

### Added

Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ If you haven't already, follow the instructions in [Development](#development) t
npm run dev-package
```

This builds a file that looks like `swift-[version]-dev.vsix`. Now install the extension with:
This builds a file that looks like `swift-vscode-[version]-dev.vsix`. Now install the extension with:

```sh
code --install-extension swift-[version]-dev.vsix
code --install-extension swift-vscode-[version]-dev.vsix
```

Alternatively you can install the extension from the Extensions panel by clicking the `...` button at the top of the panel and choosing `Install from VSIX...`.
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ To give clarity of what is expected of our members, Swift has adopted the code o

## Installation

For the extension to work, you must have Swift installed on your system. Please see the [Getting Started Guide on Swift.org](https://www.swift.org/getting-started/) for details on how to install Swift on your system. Install the extension from [VS Code Marketplace](https://marketplace.visualstudio.com/items?itemName=swiftlang.swift) and open a Swift package! You'll be prompted to install and configure the CodeLLDB extension, which you should do so.
For the extension to work, you must have Swift installed on your system. Please see the [Getting Started Guide on Swift.org](https://www.swift.org/getting-started/) for details on how to install Swift on your system. Install the extension from [VS Code Marketplace](https://marketplace.visualstudio.com/items?itemName=swiftlang.swift-vscode) and open a Swift package! You'll be prompted to install and configure the CodeLLDB extension, which you should do so.

## Features

Expand Down
4 changes: 2 additions & 2 deletions docs/remote-dev.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ First create the directory. Next, create `devcontainer.json` and insert the foll
"name": "Swift 5.5",
"image": "swift:5.5",
"extensions": [
"swiftlang.swift"
"swiftlang.swift-vscode"
],
"settings": {
"lldb.library": "/usr/lib/liblldb.so"
Expand Down Expand Up @@ -73,7 +73,7 @@ Your `devcontainer.json` should look something like this
"service": "app",
"workspaceFolder": "/workspace",
"extensions": [
"swiftlang.swift",
"swiftlang.swift-vscode",
],
"settings": {
"lldb.library": "/usr/lib/liblldb.so"
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "swift",
"displayName": "Swift",
"name": "swift-vscode",
"displayName": "Swift Programming Language",
"description": "Swift Language Support for Visual Studio Code.",
"version": "2.0.0",
"publisher": "swiftlang",
Expand Down
4 changes: 2 additions & 2 deletions test/integration-tests/ExtensionActivation.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ suite("Extension Activation/Deactivation Tests", () => {

async function activate(currentTest?: Mocha.Test) {
assert.ok(await activateExtension(currentTest), "Extension did not return its API");
const ext = vscode.extensions.getExtension("swiftlang.swift");
const ext = vscode.extensions.getExtension("swiftlang.swift-vscode");
assert.ok(ext, "Extension is not found");
assert.strictEqual(ext.isActive, true);
}
Expand All @@ -57,7 +57,7 @@ suite("Extension Activation/Deactivation Tests", () => {
test("Deactivation", async function () {
const workspaceContext = await activateExtension(this.test as Mocha.Test);
await deactivateExtension();
const ext = vscode.extensions.getExtension("swiftlang.swift");
const ext = vscode.extensions.getExtension("swiftlang.swift-vscode");
assert(ext);
assert.equal(workspaceContext.subscriptions.length, 0);
});
Expand Down
4 changes: 2 additions & 2 deletions test/integration-tests/utilities/testutilities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ const extensionBootstrapper = (() => {
`Extension is already activated. Last test that activated the extension: ${lastTestName}`
);
}
const extensionId = "swiftlang.swift";
const extensionId = "swiftlang.swift-vscode";
const ext = vscode.extensions.getExtension<Api>(extensionId);
if (!ext) {
throw new Error(`Unable to find extension "${extensionId}"`);
Expand All @@ -138,7 +138,7 @@ const extensionBootstrapper = (() => {
let workspaceContext: WorkspaceContext | undefined;

// We can only _really_ call activate through
// `vscode.extensions.getExtension<Api>("swiftlang.swift")` once.
// `vscode.extensions.getExtension<Api>("swiftlang.swift-vscode")` once.
// Subsequent activations must be done through the returned API object.
if (!activator) {
activatedAPI = await ext.activate();
Expand Down

0 comments on commit e4500d6

Please sign in to comment.