Fix nightly debugging test failures #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbastien
added
the
full-test-run
matthewbastien
requested review from
adam-fowler,
0xTim and
award999
as code owners
matthewbastien
force-pushed
the
fix-debugging-tests
branch
2 times, most recently
from
8efc158 to
3063a45
Compare
matthewbastien
changed the title
matthewbastien
force-pushed
the
fix-debugging-tests
branch
from
3063a45 to
35c16d6
Compare
|
@matthewbastien pre-6.0 you may have to disable these tests or use codelldb |
matthewbastien
force-pushed
the
fix-debugging-tests
branch
2 times, most recently
from
324f079 to
82459fd
Compare
matthewbastien
force-pushed
the
fix-debugging-tests
branch
from
74bf679 to
954bd47
Compare
matthewbastien
force-pushed
the
fix-debugging-tests
branch
from
954bd47 to
e5a7e29
Compare
award999
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to launch configuration options and prompts for CodeLLDB broke the nightly tests. Fix those issues here by:
swiftlaunch config type instead ofswift-lldbswift.debugger.debugAdapterto set the debug adapter that the tests useswift.debugger.setupCodeLLDBthat controls how CodeLLDB settings are updated. Tests now set this to"alwaysUpdateGlobal"so that they don't have to deal with the prompt at all.I also had to disable the use of
liblldbin tests with Swift versions <5.10 since those versions ofliblldbdon't seem to be compatible with CodeLLDB. The tests fail to start due to the debug adapter crashing.