Add tests #116
Add tests #116
Conversation
Playwright test results
Details
Skipped testschromium → preload-plugin.spec.ts → active links → preloads links on touchstart |
|
Besutiful! Is the changed argument order a breaking change? |
|
@hirasso No, swup currently accepts both old and new hook argument order. This change just updates to the current canonical order. |
|
@hirasso Ah, I misread your question. The updated arguments are for the call to |
|
Ah ok 👌 |
| { | ||
| "public": "tests/fixtures", | ||
| "cleanUrls": false, | ||
| "redirects": [ |
There was a problem hiding this comment.
do we need the redirects directive here?
There was a problem hiding this comment.
We currently don't test the expected behavior for redirected requests, but I think we should. For example, 302 redirects probably shouldn't preload, but we don't know the exact status code, so we should discard all redirected responses anyway.
| 'tests/unit/**/*.test.ts' | ||
| ], | ||
| setupFiles: [ | ||
| 'tests/config/vitest.setup.ts' |
There was a problem hiding this comment.
Leaving this here so we can quickly use it should we need it sometime later?
There was a problem hiding this comment.
I think so — let's merge this for now, and then do a more thorough review when comparing all plugins with e2e tests.
| @@ -0,0 +1,13 @@ | |||
| import { vi } from 'vitest'; | |||
There was a problem hiding this comment.
Unused right now – leaving it here for future usage?
|
I guess all my comments about unused stuff also apply to fragment plugin :) ...no big deal, we can totally leave it in. |
Description
Checks
masterbranchnpm run lint)npm run test)The documentation was updated as requiredRequired changes
touchstartto work properly 🤔page:preloadhook