Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add string support to IOKey values #11

Conversation

mehmetozsoy-synnada
Copy link
Collaborator

@mehmetozsoy-synnada mehmetozsoy-synnada commented Nov 15, 2024

Description

Closes #10.

What is Changed

  • Two tests added for IOKey string value handling
  • Added str to corresponding fields

Checklist:

  • Tests that cover the code added.
  • Corresponding changes documented.
  • All tests passed.
  • The code linted and styled (pre-commit run --all-files has passed).

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.69%. Comparing base (725b745) to head (727e652).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   85.69%   85.69%           
=======================================
  Files          61       61           
  Lines       15224    15224           
=======================================
  Hits        13046    13046           
  Misses       2178     2178           
Files with missing lines Coverage Δ
mithril/framework/codegen/python_gen.py 95.67% <ø> (ø)
mithril/framework/common.py 95.76% <ø> (ø)
mithril/framework/constraints.py 94.26% <100.00%> (ø)
mithril/framework/logical/base.py 87.44% <100.00%> (ø)
mithril/framework/logical/model.py 96.25% <100.00%> (ø)
mithril/framework/physical/data_store.py 95.56% <100.00%> (ø)
mithril/framework/physical/flat_graph.py 95.58% <ø> (ø)

@kberat-synnada kberat-synnada merged commit 2a98f88 into synnada-ai:main Nov 15, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add string support to IOKey's value
2 participants