-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Make IOKey dataclass derived from BaseKey #117
Merged
norhan-synnada
merged 12 commits into
synnada-ai:main
from
kberat-synnada:update-IOKey-connections
Dec 26, 2024
Merged
refactor: Make IOKey dataclass derived from BaseKey #117
norhan-synnada
merged 12 commits into
synnada-ai:main
from
kberat-synnada:update-IOKey-connections
Dec 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… refactor-extend
…to set of Connection or str
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 86.71% 86.52% -0.19%
==========================================
Files 61 61
Lines 15616 15617 +1
==========================================
- Hits 13541 13513 -28
- Misses 2075 2104 +29
|
norhan-synnada
approved these changes
Dec 26, 2024
aturker-synnada
approved these changes
Dec 26, 2024
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #116 and #118.
Checklist: