Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make IOKey dataclass derived from BaseKey #117

Merged

Conversation

kberat-synnada
Copy link
Collaborator

@kberat-synnada kberat-synnada commented Dec 25, 2024

Description

Closes #116 and #118.

Checklist:

  • Tests that cover the code added.
  • Corresponding changes documented.
  • All tests passed.
  • The code linted and styled (pre-commit run --all-files has passed).

@kberat-synnada kberat-synnada changed the title refactor: Update IOkey _connections field and rename refactor: Update IOkey _connections field and rename shape method of TemplateBase Dec 25, 2024
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 89.18919% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.52%. Comparing base (de07573) to head (45cacb1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
mithril/utils/dict_conversions.py 0.00% 6 Missing ⚠️
mithril/framework/common.py 88.88% 2 Missing ⚠️
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   86.71%   86.52%   -0.19%     
==========================================
  Files          61       61              
  Lines       15616    15617       +1     
==========================================
- Hits        13541    13513      -28     
- Misses       2075     2104      +29     
Files with missing lines Coverage Δ
mithril/framework/logical/base.py 88.01% <100.00%> (-0.03%) ⬇️
mithril/framework/logical/essential_primitives.py 99.58% <100.00%> (ø)
mithril/framework/logical/model.py 97.48% <100.00%> (-0.01%) ⬇️
mithril/framework/logical/primitive.py 95.45% <100.00%> (+0.04%) ⬆️
mithril/models/models.py 88.55% <100.00%> (ø)
mithril/models/primitives.py 97.46% <100.00%> (ø)
mithril/framework/common.py 96.45% <88.88%> (-0.11%) ⬇️
mithril/utils/dict_conversions.py 80.25% <0.00%> (-8.60%) ⬇️

@kberat-synnada kberat-synnada changed the title refactor: Update IOkey _connections field and rename shape method of TemplateBase refactor: Make IOKey dataclass derived from BaseKey Dec 25, 2024
@kberat-synnada kberat-synnada mentioned this pull request Dec 26, 2024
4 tasks
@aturker-synnada
Copy link
Collaborator

LGTM!

@norhan-synnada norhan-synnada merged commit 7b53394 into synnada-ai:main Dec 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER] Rename shape method of TemplateBase
4 participants