Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Unify PrimitiveSlice and Scalaritem #128

Conversation

mehmetozsoy-synnada
Copy link
Collaborator

Description

Include a brief and concise description of the PR.

What is Changed

Include the changes introduced in this PR.

  • __getitem__ of ExtendTemplate is updated
  • PrimitiveSlice model is removed
  • constraints of PrimitiveSlice is updated

Checklist:

  • Tests that cover the code added.
  • Corresponding changes documented.
  • All tests passed.
  • The code linted and styled (pre-commit run --all-files has passed).

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.75%. Comparing base (d62bce2) to head (a50e111).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
mithril/framework/constraints.py 93.33% 2 Missing ⚠️
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   88.75%   88.75%   -0.01%     
==========================================
  Files          61       61              
  Lines       15502    15558      +56     
==========================================
+ Hits        13759    13808      +49     
- Misses       1743     1750       +7     
Files with missing lines Coverage Δ
mithril/framework/common.py 96.68% <100.00%> (+0.12%) ⬆️
mithril/framework/logical/essential_primitives.py 99.55% <ø> (-0.02%) ⬇️
mithril/framework/logical/model.py 97.49% <100.00%> (+<0.01%) ⬆️
mithril/framework/physical/model.py 89.19% <100.00%> (+0.26%) ⬆️
mithril/framework/constraints.py 94.98% <93.33%> (-0.02%) ⬇️

... and 4 files with indirect coverage changes

@kberat-synnada kberat-synnada merged commit 9b7b730 into synnada-ai:main Dec 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants