Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove factory inputs #130

Merged
merged 5 commits into from
Dec 30, 2024

Conversation

kberat-synnada
Copy link
Collaborator

Description

Closes #129.

What is Changed

  • Removal of factory_inputs attribute.
  • Removal of factory_inputs from all Primitive and Logical models.
  • Simplification on BaseModel call method.
  • Corresponding tests updated.
  • Minor merge bug in backend and PhysicalModel that fails main CI (unrelated to this PR) resolved.

Checklist:

  • Tests that cover the code added.
  • Corresponding changes documented.
  • All tests passed.
  • The code linted and styled (pre-commit run --all-files has passed).

…fied, tests updated, minor merge bug in backend (unrelated to this commit) resolved
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 88.77551% with 11 lines in your changes missing coverage. Please review.

Project coverage is 88.64%. Comparing base (9b7b730) to head (13fa076).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
mithril/models/models.py 84.72% 11 Missing ⚠️
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   88.75%   88.64%   -0.11%     
==========================================
  Files          61       61              
  Lines       15558    15391     -167     
==========================================
- Hits        13808    13643     -165     
+ Misses       1750     1748       -2     
Files with missing lines Coverage Δ
...hril/backends/with_autograd/jax_backend/backend.py 82.98% <100.00%> (ø)
mithril/framework/common.py 96.68% <100.00%> (ø)
mithril/framework/logical/base.py 87.66% <ø> (-0.51%) ⬇️
mithril/framework/logical/essential_primitives.py 99.50% <100.00%> (-0.06%) ⬇️
mithril/framework/logical/model.py 97.10% <ø> (-0.39%) ⬇️
mithril/models/primitives.py 97.23% <100.00%> (-0.24%) ⬇️
mithril/models/models.py 88.68% <84.72%> (-0.02%) ⬇️

@github-actions github-actions bot added common and removed physical labels Dec 30, 2024
@norhan-synnada norhan-synnada merged commit a0e6b1b into synnada-ai:main Dec 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER] Remove factory_inputs attribute
3 participants