Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Linted Physical folder #138

Merged

Conversation

mehmetozsoy-synnada
Copy link
Collaborator

@mehmetozsoy-synnada mehmetozsoy-synnada commented Jan 2, 2025

Description

Closes #137.

What is Changed

  • Physical is linted based on Mypy's strict mode
  • base.py is linted
  • some functions in backend is linted

Checklist:

  • Tests that cover the code added.
  • Corresponding changes documented.
  • All tests passed.
  • The code linted and styled (pre-commit run --all-files has passed).

mehmetozsoy-synnada and others added 30 commits November 14, 2024 10:16
…ions bot will request a change if PR title does not follow Conventional format
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 98.82353% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.78%. Comparing base (3a1fc42) to head (4d48eda).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
mithril/framework/common.py 92.30% 1 Missing ⚠️
mithril/framework/physical/model.py 96.96% 1 Missing ⚠️
mithril/framework/utils.py 87.50% 1 Missing ⚠️
@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage   88.78%   88.78%           
=======================================
  Files          61       61           
  Lines       15357    15359    +2     
=======================================
+ Hits        13635    13637    +2     
  Misses       1722     1722           
Files with missing lines Coverage Δ
mithril/backends/backend.py 63.95% <100.00%> (ø)
mithril/backends/parallel.py 90.00% <100.00%> (ø)
...ithril/backends/with_autograd/common_primitives.py 66.40% <100.00%> (ø)
...hril/backends/with_autograd/jax_backend/backend.py 82.98% <100.00%> (ø)
mithril/backends/with_autograd/jax_backend/ops.py 85.35% <100.00%> (ø)
...ril/backends/with_autograd/jax_backend/parallel.py 34.21% <100.00%> (ø)
...ithril/backends/with_autograd/jax_backend/utils.py 70.52% <100.00%> (ø)
...hril/backends/with_autograd/mlx_backend/backend.py 63.06% <100.00%> (ø)
...hril/backends/with_manualgrad/c_backend/backend.py 80.95% <100.00%> (ø)
...hril/backends/with_manualgrad/numpy_backend/ops.py 85.56% <100.00%> (ø)
... and 18 more

@kberat-synnada kberat-synnada merged commit 941bb50 into synnada-ai:main Jan 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER] Lint Physical strictly
3 participants