Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dtype Parameter to Array Creation Primitives #165

Merged

Conversation

aturker-synnada
Copy link
Collaborator

Description

Closes #143

What is Changed

  • Array creation primitives now take dtype parameter.

Checklist:

  • Tests that cover the code added.
  • Corresponding changes documented.
  • All tests passed.
  • The code linted and styled (pre-commit run --all-files has passed).

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 96.55172% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.74%. Comparing base (06f9445) to head (b36a2dc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
mithril/backends/with_autograd/mlx_backend/ops.py 88.00% 3 Missing ⚠️
mithril/backends/backend.py 66.66% 2 Missing ⚠️
...ithril/backends/with_autograd/mlx_backend/utils.py 60.00% 2 Missing ⚠️
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   89.05%   88.74%   -0.32%     
==========================================
  Files          61       61              
  Lines       15754    15857     +103     
==========================================
+ Hits        14030    14072      +42     
- Misses       1724     1785      +61     
Files with missing lines Coverage Δ
...hril/backends/with_autograd/jax_backend/backend.py 84.56% <100.00%> (+0.31%) ⬆️
mithril/backends/with_autograd/jax_backend/ops.py 86.09% <100.00%> (+0.55%) ⬆️
...ithril/backends/with_autograd/jax_backend/utils.py 62.71% <100.00%> (-8.32%) ⬇️
...hril/backends/with_autograd/mlx_backend/backend.py 71.53% <100.00%> (+1.34%) ⬆️
...il/backends/with_autograd/torch_backend/backend.py 92.56% <100.00%> (+0.15%) ⬆️
...ithril/backends/with_autograd/torch_backend/ops.py 80.64% <100.00%> (+0.81%) ⬆️
...hril/backends/with_autograd/torch_backend/utils.py 76.16% <100.00%> (-5.47%) ⬇️
.../backends/with_manualgrad/numpy_backend/backend.py 89.16% <100.00%> (+0.33%) ⬆️
...hril/backends/with_manualgrad/numpy_backend/ops.py 86.22% <100.00%> (+0.51%) ⬆️
...il/backends/with_manualgrad/numpy_backend/utils.py 66.47% <100.00%> (-8.38%) ⬇️
... and 11 more

... and 2 files with indirect coverage changes

@kberat-synnada kberat-synnada merged commit 0726ad4 into synnada-ai:main Jan 23, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Array creation primitives (e.g., arange, randn, etc.) should accept a dtype parameter
3 participants