Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update Model Architecture with User-interacting Logic #174

Merged

Conversation

kberat-synnada
Copy link
Collaborator

Description

Closes #173.

Checklist:

  • Tests that cover the code added.
  • Corresponding changes documented.
  • All tests passed.
  • The code linted and styled (pre-commit run --all-files has passed).

…erted to have single Op model in its dag, removal of _register_base_keys, removal of wrapping primitives in compile
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 95.95415% with 60 lines in your changes missing coverage. Please review.

Project coverage is 88.96%. Comparing base (61bf174) to head (a268fbb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
mithril/framework/logical/model.py 93.26% 20 Missing ⚠️
mithril/framework/logical/base.py 96.29% 17 Missing ⚠️
mithril/utils/dict_conversions.py 46.15% 7 Missing ⚠️
mithril/framework/physical/model.py 88.46% 3 Missing ⚠️
mithril/models/primitives.py 99.17% 3 Missing ⚠️
mithril/models/train_model.py 93.18% 3 Missing ⚠️
mithril/framework/logical/operator.py 96.87% 2 Missing ⚠️
mithril/framework/physical/flat_graph.py 90.47% 2 Missing ⚠️
mithril/framework/codegen/numpy_gen.py 85.71% 1 Missing ⚠️
mithril/framework/common.py 95.83% 1 Missing ⚠️
... and 1 more
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   88.79%   88.96%   +0.16%     
==========================================
  Files          61       62       +1     
  Lines       16010    16297     +287     
==========================================
+ Hits        14216    14498     +282     
- Misses       1794     1799       +5     
Files with missing lines Coverage Δ
mithril/__init__.py 78.18% <100.00%> (+0.40%) ⬆️
mithril/framework/codegen/python_gen.py 95.98% <100.00%> (ø)
mithril/framework/codegen/torch_gen.py 100.00% <100.00%> (ø)
mithril/framework/logical/__init__.py 100.00% <100.00%> (ø)
mithril/framework/logical/operators.py 100.00% <100.00%> (ø)
mithril/framework/logical/primitive.py 100.00% <100.00%> (+3.84%) ⬆️
mithril/framework/utils.py 88.40% <100.00%> (-0.63%) ⬇️
mithril/models/models.py 90.09% <100.00%> (+0.92%) ⬆️
mithril/framework/codegen/numpy_gen.py 92.67% <85.71%> (+0.48%) ⬆️
mithril/framework/common.py 97.04% <95.83%> (+0.54%) ⬆️
... and 9 more

... and 2 files with indirect coverage changes

@norhan-synnada norhan-synnada merged commit 8fb0a5d into synnada-ai:main Feb 7, 2025
8 checks passed
mehmetozsoy-synnada pushed a commit to mehmetozsoy-synnada/mithril that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Update Model Architecture with User-interacting & Non-interacting
4 participants