-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Update Model Architecture with User-interacting Logic #174
Merged
norhan-synnada
merged 16 commits into
synnada-ai:main
from
kberat-synnada:add-user-interacting-model-logic
Feb 7, 2025
Merged
feat!: Update Model Architecture with User-interacting Logic #174
norhan-synnada
merged 16 commits into
synnada-ai:main
from
kberat-synnada:add-user-interacting-model-logic
Feb 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erted to have single Op model in its dag, removal of _register_base_keys, removal of wrapping primitives in compile
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 88.79% 88.96% +0.16%
==========================================
Files 61 62 +1
Lines 16010 16297 +287
==========================================
+ Hits 14216 14498 +282
- Misses 1794 1799 +5
|
aturker-synnada
approved these changes
Feb 7, 2025
mehmetozsoy-synnada
approved these changes
Feb 7, 2025
norhan-synnada
approved these changes
Feb 7, 2025
mehmetozsoy-synnada
pushed a commit
to mehmetozsoy-synnada/mithril
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #173.
Checklist: