Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add VALUE type to constraints #176

Conversation

mehmetozsoy-synnada
Copy link
Collaborator

Description

Closes #175.

What is Changed

  • VALUE type is introduced
  • type of constraints are updated

Checklist:

  • Tests that cover the code added.
  • Corresponding changes documented.
  • All tests passed.
  • The code linted and styled (pre-commit run --all-files has passed).

…ions bot will request a change if PR title does not follow Conventional format
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.71%. Comparing base (5a07669) to head (532b788).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
mithril/framework/constraints.py 50.00% 2 Missing ⚠️
mithril/framework/physical/model.py 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
- Coverage   88.71%   88.71%   -0.01%     
==========================================
  Files          61       61              
  Lines       15979    15970       -9     
==========================================
- Hits        14175    14167       -8     
+ Misses       1804     1803       -1     
Files with missing lines Coverage Δ
mithril/framework/common.py 96.49% <100.00%> (-0.02%) ⬇️
mithril/framework/logical/base.py 87.64% <100.00%> (ø)
mithril/framework/physical/data_store.py 95.27% <100.00%> (+0.04%) ⬆️
mithril/framework/physical/model.py 92.45% <0.00%> (ø)
mithril/framework/constraints.py 93.77% <50.00%> (+0.04%) ⬆️

@kberat-synnada kberat-synnada merged commit d8dd269 into synnada-ai:main Feb 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER] add VALUE as Update types.
4 participants