New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent zero-probability events from being sampled in multinomial function in Jax-backend #177

Merged

ozankabak merged 5 commits into synnada-ai:main from SinanGncgl:fix-jax-backend-zero-probability-sampling

Feb 4, 2025

Merged

fix: prevent zero-probability events from being sampled in multinomial function in Jax-backend #177

fix typo input->probs

Codecov / codecov/patch failed Feb 1, 2025 in 1s

0.00% of diff hit (target 88.71%)

View this Pull Request on Codecov

0.00% of diff hit (target 88.71%)

Annotations

Check warning on line 517 in mithril/backends/with_autograd/jax_backend/backend.py

codecov / codecov/patch

mithril/backends/with_autograd/jax_backend/backend.py#L516-L517

Added lines #L516 - L517 were not covered by tests

Check warning on line 520 in mithril/backends/with_autograd/jax_backend/backend.py

codecov / codecov/patch

mithril/backends/with_autograd/jax_backend/backend.py#L520

Added line #L520 was not covered by tests

Check warning on line 535 in mithril/backends/with_autograd/jax_backend/backend.py

codecov / codecov/patch

mithril/backends/with_autograd/jax_backend/backend.py#L535

Added line #L535 was not covered by tests

Check warning on line 539 in mithril/backends/with_autograd/jax_backend/backend.py

codecov / codecov/patch

mithril/backends/with_autograd/jax_backend/backend.py#L539

Added line #L539 was not covered by tests

View more details on Codecov