Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor Differentiability #185

Merged

Conversation

aturker-synnada
Copy link
Collaborator

Description

Closes #184.

What is Changed

Include the changes introduced in this PR.

  • Differentiability flag now in Tensor.
  • PM infer_differentiability logic is changed.

Checklist:

  • Tests that cover the code added.
  • Corresponding changes documented.
  • All tests passed.
  • The code linted and styled (pre-commit run --all-files has passed).

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.97%. Comparing base (8fb0a5d) to head (bb092a9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
mithril/framework/common.py 93.54% 2 Missing ⚠️
mithril/framework/logical/base.py 87.50% 2 Missing ⚠️
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   88.96%   88.97%   +0.01%     
==========================================
  Files          62       62              
  Lines       16297    16311      +14     
==========================================
+ Hits        14498    14513      +15     
+ Misses       1799     1798       -1     
Files with missing lines Coverage Δ
mithril/framework/logical/model.py 94.08% <100.00%> (+0.04%) ⬆️
mithril/framework/logical/operator.py 96.96% <100.00%> (+0.09%) ⬆️
mithril/framework/logical/operators.py 100.00% <100.00%> (ø)
mithril/framework/logical/primitive.py 100.00% <100.00%> (ø)
mithril/framework/physical/model.py 91.60% <100.00%> (-0.03%) ⬇️
mithril/models/models.py 90.06% <100.00%> (-0.03%) ⬇️
mithril/models/primitives.py 98.00% <ø> (-0.01%) ⬇️
mithril/models/train_model.py 91.97% <100.00%> (+0.02%) ⬆️
mithril/utils/dict_conversions.py 81.42% <100.00%> (ø)
mithril/framework/common.py 97.01% <93.54%> (-0.03%) ⬇️
... and 1 more

... and 2 files with indirect coverage changes

@kberat-synnada
Copy link
Collaborator

Issue explanation (#184) is not clear

@kberat-synnada kberat-synnada merged commit 5b9d92c into synnada-ai:main Feb 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER] Refactor Differentiability
4 participants