Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update set_values, set_shapes and set_types methods of BaseModel #21

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

norhan-synnada
Copy link
Collaborator

@norhan-synnada norhan-synnada commented Nov 21, 2024

Description

Closes #14.

What is Changed

  • Available types of arguments and corresponding handlings updated.

Checklist:

  • Tests that cover the code added.
  • Corresponding changes documented.
  • All tests passed.
  • The code linted and styled (pre-commit run --all-files has passed).

@norhan-synnada norhan-synnada self-assigned this Nov 21, 2024
@ozankabak ozankabak changed the title feat: Update set methods of BaseModel feat: Update set_values, set_shapes and set_types methods of BaseModel Nov 21, 2024
@norhan-synnada norhan-synnada changed the title feat: Update set_values, set_shapes and set_types methods of BaseModel feat: Update set_values, set_shapes and set_types methods of BaseModel Nov 21, 2024
@norhan-synnada norhan-synnada changed the title feat: Update set_values, set_shapes and set_types methods of BaseModel feat: Update "set_values", " set_shapes" and "set_types" methods of "BaseModel" Nov 21, 2024
@norhan-synnada norhan-synnada changed the title feat: Update "set_values", " set_shapes" and "set_types" methods of "BaseModel" feat: Update set_values, set_shapes and set_types methods of BaseModel Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.92%. Comparing base (39e3eb0) to head (6ee875f).
Report is 3 commits behind head on main.

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   85.90%   85.92%   +0.01%     
==========================================
  Files          61       61              
  Lines       15249    15257       +8     
==========================================
+ Hits        13100    13109       +9     
+ Misses       2149     2148       -1     
Files with missing lines Coverage Δ
mithril/framework/logical/base.py 87.86% <100.00%> (+0.22%) ⬆️
mithril/utils/dict_conversions.py 88.78% <100.00%> (ø)

... and 1 file with indirect coverage changes


🚨 Try these New Features:

@norhan-synnada norhan-synnada changed the title feat: Update set_values, set_shapes and set_types methods of BaseModel feat: Update set_values, set_shapes and set_types methods of `BaseModel Nov 21, 2024
@norhan-synnada norhan-synnada changed the title feat: Update set_values, set_shapes and set_types methods of `BaseModel feat: Update set_values, set_shapes and set_types methods of BaseModel Nov 21, 2024
@kberat-synnada kberat-synnada merged commit b98d025 into synnada-ai:main Nov 22, 2024
5 checks passed
@norhan-synnada norhan-synnada deleted the update_set_functions branch November 25, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] set_values, set_shapes, set_types should accept both dict and keyword arguments.
3 participants