Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Valued connections should not be canonical input #91

Merged

Conversation

aturker-synnada
Copy link
Collaborator

Description

Closes #89

What is Changed

Include the changes introduced in this PR.

  • Updated canonical input rule

Checklist:

  • Tests that cover the code added.
  • Corresponding changes documented.
  • All tests passed.
  • The code linted and styled (pre-commit run --all-files has passed).

@aturker-synnada aturker-synnada changed the title fix: Valued connections should be canonical input fix: Valued connections should not be canonical input Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.56%. Comparing base (d65f1e7) to head (2d1eb74).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
mithril/framework/logical/model.py 87.50% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   86.57%   86.56%   -0.01%     
==========================================
  Files          61       61              
  Lines       15587    15588       +1     
==========================================
  Hits        13494    13494              
- Misses       2093     2094       +1     
Files with missing lines Coverage Δ
mithril/framework/logical/model.py 96.61% <87.50%> (-0.18%) ⬇️

@norhan-synnada norhan-synnada merged commit 3ff233a into synnada-ai:main Dec 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Valued connections should not be canonical input
3 participants