Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add connections field to IOKey and remove Connect object #94

Merged

Conversation

kberat-synnada
Copy link
Collaborator

Description

Closes #93.

What is Changed

  • "connections" argument and attribute added to IOKey.
  • Connect object is removed.
  • Corresponding tests are updated.

Checklist:

  • Tests that cover the code added.
  • Corresponding changes documented.
  • All tests passed.
  • The code linted and styled (pre-commit run --all-files has passed).

@kberat-synnada kberat-synnada changed the title Add connections field to IOKey and remove Connect object feat: Add connections field to IOKey and remove Connect object Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.58%. Comparing base (d65f1e7) to head (fce6951).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   86.57%   86.58%           
=======================================
  Files          61       61           
  Lines       15587    15575   -12     
=======================================
- Hits        13494    13485    -9     
+ Misses       2093     2090    -3     
Files with missing lines Coverage Δ
mithril/__init__.py 80.70% <100.00%> (ø)
mithril/framework/common.py 96.50% <100.00%> (-0.01%) ⬇️
mithril/framework/logical/base.py 88.04% <100.00%> (-0.16%) ⬇️
mithril/framework/logical/model.py 97.11% <100.00%> (+0.33%) ⬆️
mithril/utils/dict_conversions.py 88.85% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

@aturker-synnada
Copy link
Collaborator

LGTM!

@norhan-synnada norhan-synnada merged commit 3cf4ae0 into synnada-ai:main Dec 18, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add "connections" argument into IOKey
3 participants