Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): explain how storage variables get updated #1311

Merged
merged 9 commits into from
Jan 21, 2025
Merged

feat(docs): explain how storage variables get updated #1311

merged 9 commits into from
Jan 21, 2025

Conversation

novusnota
Copy link
Member

@novusnota novusnota commented Jan 14, 2025 •
edited
Loading

Issue

Closes #1095.
Towards #713.

Checklist

  • I have updated CHANGELOG.md
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@novusnota novusnota added this to the Doc: 2025-01 milestone Jan 14, 2025
@novusnota novusnota requested a review from a team as a code owner January 14, 2025 04:29
anton-trunov
anton-trunov requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not resolve #1095, to actually resolve it you need to incorporate and expand this comment:

#712 (comment)

It looks like this PR is trying to resolve #713

docs/src/content/docs/book/contracts.mdx Outdated Show resolved Hide resolved
@novusnota
Copy link
Member Author

novusnota commented Jan 14, 2025 •
edited
Loading

This PR does not resolve #1095, to actually resolve it you need to incorporate and expand this comment:

#712 (comment)

Sure, I'll add more while removing the redundancies.

It looks like this PR is trying to resolve #713

Well, it wasn't labeled as a doc issue, but as a testing & typechecker, so I don't think this PR needs to be marked as closing it.

@anton-trunov anton-trunov self-assigned this Jan 14, 2025
@anton-trunov
Copy link
Member

Please finish this ASAP

@novusnota
Copy link
Member Author

Please finish this ASAP

Ready for review

@anton-trunov anton-trunov merged commit 22862fc into main Jan 21, 2025
17 of 18 checks passed
@anton-trunov anton-trunov deleted the closes-1095 branch January 21, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
Doc: 2025-01
Development

Successfully merging this pull request may close these issues.

Explain how storage variables get updated
2 participants
@novusnota @anton-trunov